Fix MakerWorld 2FA duplicate email loop and add email SMTP diagnostics

This commit is contained in:
2026-11-01 15:46:00 +01:00
parent 2d78d80934
commit 09285d0a46
12 changed files with 425 additions and 8 deletions
@@ -6,6 +6,8 @@ use App\Http\Controllers\Controller;
use App\Models\Setting;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Mail;
use Illuminate\View\View;
class ContentController extends Controller
@@ -132,4 +134,38 @@ class ContentController extends Controller
return redirect()->route('admin.content.index')
->with('success', 'Alle teksten en lay-out instellingen zijn hersteld naar de standaarden.');
}
/**
* Send a test email to verify mail delivery (e.g. to Gmail).
*/
public function sendTestMail(Request $request): RedirectResponse
{
$validated = $request->validate([
'test_email' => 'required|email',
]);
$recipient = $validated['test_email'];
$defaultMailer = config('mail.default');
$fromAddress = config('mail.from.address');
try {
Mail::raw("Dit is een test e-mail vanaf Jouwdriedee.nl om de e-mail bezorging naar {$recipient} te controleren.\n\nActieve mailer: {$defaultMailer}\nAfzender: {$fromAddress}\nDatum: ".now()->format('d-m-Y H:i:s'), function ($message) use ($recipient) {
$message->to($recipient)
->subject('Test E-mail vanaf Jouwdriedee.nl');
});
if ($defaultMailer === 'log') {
return redirect()->back()
->with('warning', "De testmail is weggeschreven naar de serverlogs (MAIL_MAILER staat op 'log'). Er is GEEN echte e-mail naar {$recipient} verzonden. Stel op Coolify geldige SMTP-gegevens in (bijv. Brevo, Resend of je hosting SMTP) om echte e-mails te bezorgen.");
}
return redirect()->back()
->with('success', "Test e-mail succesvol verzonden via driver '{$defaultMailer}' naar {$recipient}! Controleer je inbox en eventueel je spambox.");
} catch (\Throwable $e) {
Log::error('Test mail error: '.$e->getMessage(), ['trace' => $e->getTraceAsString()]);
return redirect()->back()
->with('error', "Fout bij verzenden van e-mail via {$defaultMailer}: ".$e->getMessage());
}
}
}
@@ -337,13 +337,13 @@ class MakerWorldController extends Controller
if ($result['status'] === '2fa_required') {
return redirect()
->route('admin.makerworld.index')
->route('admin.makerworld.index', ['tab' => 'auth'])
->with('warning', $result['message'])
->with('makerworld_2fa_account', $result['account']);
}
return redirect()
->route('admin.makerworld.index')
->route('admin.makerworld.index', ['tab' => 'auth'])
->with('error', $result['message']);
}
@@ -369,11 +369,28 @@ class MakerWorldController extends Controller
}
return redirect()
->route('admin.makerworld.index')
->route('admin.makerworld.index', ['tab' => 'auth'])
->with('error', $result['message'])
->with('makerworld_2fa_account', $validated['account']);
}
/**
* Resend verification code for 2FA manually on request.
*/
public function resendCode(Request $request): RedirectResponse
{
$validated = $request->validate([
'account' => 'required|string',
]);
$sent = $this->makerWorld->sendEmailVerificationCode($validated['account']);
return redirect()
->route('admin.makerworld.index', ['tab' => 'auth'])
->with($sent ? 'success' : 'error', $sent ? 'Er is een nieuwe verificatiecode verstuurd naar je e-mail.' : 'Kon verificatiecode niet opnieuw verzenden.')
->with('makerworld_2fa_account', $validated['account']);
}
/**
* Save MakerWorld session / bearer token directly.
*/
@@ -11,6 +11,7 @@ use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Str;
use Illuminate\Validation\ValidationException;
@@ -61,6 +62,7 @@ class ForgotPasswordController extends Controller
try {
Mail::to($user->email)->send(new PasswordResetMail($user, $resetUrl));
} catch (Throwable $e) {
Log::error("Fout bij verzenden van wachtwoordherstel e-mail naar {$user->email}: ".$e->getMessage());
report($e);
}
@@ -9,6 +9,7 @@ use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Mail;
use Illuminate\View\View;
use Throwable;
@@ -56,6 +57,7 @@ class RegisterController extends Controller
try {
Mail::to($user->email)->send(new WelcomeMail($user));
} catch (Throwable $e) {
Log::error("Fout bij verzenden van welkomstmail naar {$user->email}: ".$e->getMessage());
report($e);
}